Enable Virtual disk as storage mode in PIM #12
Merged
+256
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
manju956
changed the title
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
|
|
||
| if not storage_attached: | ||
| if not storage_attached or not vdisk_attached: | ||
| vios_storage_list = vios_operation.get_vios_with_physical_storage( |
There was a problem hiding this comment.
for vdisk also we need to check physical storage vios list?
There was a problem hiding this comment.
yes because we create virtual disk from physical storage with sufficient space.
cli/vios/vios.py
Outdated
| logger.info( | ||
| f"Removing SCSI mapping for physical disk '{phys_disk}'") | ||
| command_util.remove_scsi_mappings( | ||
| config, cookies, sys_uuid, partition_uuid, vios_uuid, vios, phys_disk) | ||
| storage_cleaned = True | ||
| # Check if attached disk is virtual disk |
There was a problem hiding this comment.
this func has become too long, please see you can refactor it to sub funcs
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
Signed-off-by: Manjunath-A-C <[email protected]>
dharaneeshvrd
approved these changes
Jul 22, 2025
|
Pls don't forget to squash the commits before merge |
sure |
Signed-off-by: Manjunath-A-C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.